Skip to content
  • Joey Hess's avatar
    simplify base64 to only use ByteString · 3742263c
    Joey Hess authored
    Note the use of fromString and toString from Data.ByteString.UTF8 dated
    back to commit 9b93278e. Back then it
    was using the dataenc package for base64, which operated on Word8 and
    String. But with the switch to sandi, it uses ByteString, and indeed
    fromB64' and toB64' were already using ByteString without that
    complication. So I think there is no risk of such an encoding related
    breakage.
    
    I also tested the case that 9b93278e
    fixed:
    
    	git-annex metadata -s foo='a …' x
    	git-annex metadata x
    	metadata x
    	  foo=a …
    
    In Remote.Helper.Encryptable, it was avoiding using Utility.Base64
    because of that UTF8 conversion. Since that's no longer done, it can
    just use it now.
    3742263c